Fix bug in audiobuffersource-duration-loop test #29289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 8, 2021
The test was producing a failure that the array lengths didn't match. (Not sure why the test was marked as passing even though it failed.) The problem was that we actually had audioBuffer.getChannelData instead of audioBuffer.getChannelData(0) to get the data from the first channel. Correct the mistake and also run clang-format over the code to clean it up. Bug: 1217791 Change-Id: I510838337e2948b89fb0622b63dd81e022d103d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2945641 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#891341}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2945641
branch
from
0fad3cb
to
77e02ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was producing a failure that the array lengths didn't match.
(Not sure why the test was marked as passing even though it failed.)
The problem was that we actually had audioBuffer.getChannelData
instead of audioBuffer.getChannelData(0) to get the data from the
first channel.
Correct the mistake and also run clang-format over the code to clean
it up.
Bug: 1217791
Change-Id: I510838337e2948b89fb0622b63dd81e022d103d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2945641
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891341}