[ResourceTiming]: Cleanup cors-preflight.any.js #29333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 10, 2021
This CL updates the cors-preflight.any.js test to conform to the new style/guidelines. In particular, some helpers have been renamed for clarity and we use a PerformanceObserver instead of calling performance.getEntriesByName(). Bug: 1171767 Change-Id: Ic6a0116e099a77a808bd9dc748f4a573ae349ad2 GitHubIssue: w3c/resource-timing#254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951092 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#891648}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2951092
branch
from
1339d7d
to
aac4b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL updates the cors-preflight.any.js test to conform to the new
style/guidelines.
In particular, some helpers have been renamed for clarity and we use a
PerformanceObserver instead of calling performance.getEntriesByName().
Bug: 1171767
Change-Id: Ic6a0116e099a77a808bd9dc748f4a573ae349ad2
GitHubIssue: w3c/resource-timing#254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951092
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891648}