Codechange: use std::string with network's ContentInfo #9315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
C-string to std::string conversion.
Description
Replace custom allocation of tags/dependencies arrays with vectors, use proper initializations and use std::string instead of string buffers.
Limitations
Maximum sizes for the fields are magic numbers. However, since they are only used ones as parameter to
Recv_String
, I'm not certain how much benefit adding some constants with those values is going to add. Then you'd need to document that it is to limit the data received from the content server, but... the only place where they are used already implies it.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.