Codechange: [Network] Remove C-string Packet::Recv_string #9347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Final step in the conversion of C-string to std::string in network packets.
Description
Change receiving the NewGRF name and OpenTTD revision to std::strings and remove the C-string Packet::Recv_String.
Limitations
Preferably IsNetworkCompatibleVersion would accept std::string or std::string_view, but it currently does not. Given the complexity of that function and the lack of unit testing ability that is left to a future PR.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.