Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8803: Automatically removing signals on rail construction would … #8904

Merged
merged 1 commit into from Mar 31, 2021
Merged

Fix #8803: Automatically removing signals on rail construction would … #8904

merged 1 commit into from Mar 31, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Mar 28, 2021

…remove signals before checking if track could actually be built

Motivation / Problem

Game would remove signals before checking whether rails could actually be built (due to terrain issues)

Description

Simple move of the slope-checking code before the signal checking code

Limitations

Commit message is a bit long! Suggestions for shortening it appreciated :p

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro
Fix OpenTTD#8803: Automatically removing signals on rail construction…
a5907e1 
… would remove signals before checking if track could actually be built
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Mar 28, 2021
@2TallTyler
Copy link
Member

How about Only auto-remove signals if rail can be built?

TrueBrain
TrueBrain approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested this. "seems legit".

@LordAro LordAro merged commit 086c957 into OpenTTD:master Mar 31, 2021
@LordAro LordAro deleted the bug8803 branch March 31, 2021 08:27
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Mar 31, 2021
@LordAro @TrueBrain
Fix OpenTTD#8803: Only auto-remove signals when rail can be built (Op…
63d8a72 
…enTTD#8904)
TrueBrain pushed a commit that referenced this pull request Apr 1, 2021
@LordAro @TrueBrain
Fix #8803: Only auto-remove signals when rail can be built (#8904)
edbae9a
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LordAro @2TallTyler @TrueBrain