[Gecko Bug 1649639] Add WPT and remove unnecessary MOZ_ASSERT of `HTMLEditor::ClearStyleAt
#28410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the method detects the style coming from a parent block, the `MOZ_ASSERT` checks whether the current mode is "style with CSS" or not because currently, `HTMLEditor` does not use `<span>` with CSS when the mode is not "style with CSS". However, fixing it requires bigger patch, and the change does not match with the bug's summary. So, I just remove the `MOZ_ASSERT`, add WPT and filed bug 1649639 for the root issue. Differential Revision: https://phabricator.services.mozilla.com/D111067 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1649639 gecko-commit: ca0c86fb52d92389c1d93dae05d011843aef3290 gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the method detects the style coming from a parent block, the
MOZ_ASSERTchecks whether the current mode is "style with CSS" or not because currently,
HTMLEditordoes not use<span>with CSS when the mode is not "style withCSS". However, fixing it requires bigger patch, and the change does not match
with the bug's summary. So, I just remove the
MOZ_ASSERT, add WPT and filedbug 1649639 for the root issue.
Differential Revision: https://phabricator.services.mozilla.com/D111067
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1649639
gecko-commit: ca0c86fb52d92389c1d93dae05d011843aef3290
gecko-reviewers: m_kato