Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSNumericValue.add and sub must throw TypeException when type different #28333

Merged
merged 1 commit into from Apr 7, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 1, 2021

According to the spec [1], CSSNumericValue.add must throw the exception
on types are different. CSSNumericValue.sub uses CSSMathSum
with negating, So it is samely required throw the exception.

Therefore, add ThrowTypeErrorIfValueIsNull() helper function
which receive the value and exception_state for throw TypeException
after checking the value is nullptr.

[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-add

Bug: 1193923
Change-Id: Ic131e641d2e3251d119eca04a0ce55f194596710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798149
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869972}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2798149 branch 3 times, most recently from c5dc240 to 6f276ae Compare April 6, 2021 03:53
According to the spec [1], CSSNumericValue.add must throw the exception
on types are different. CSSNumericValue.sub uses CSSMathSum
with negating, So it is samely required throw the exception.

Therefore, add ThrowTypeErrorIfValueIsNull() helper function
which receive the value and exception_state for throw TypeException
after checking the value is nullptr.

[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-add

Bug: 1193923
Change-Id: Ic131e641d2e3251d119eca04a0ce55f194596710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798149
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869972}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants