CSSNumericValue.add and sub must throw TypeException when type different #28333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec [1], CSSNumericValue.add must throw the exception
on types are different. CSSNumericValue.sub uses CSSMathSum
with negating, So it is samely required throw the exception.
Therefore, add ThrowTypeErrorIfValueIsNull() helper function
which receive the value and exception_state for throw TypeException
after checking the value is nullptr.
[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-add
Bug: 1193923
Change-Id: Ic131e641d2e3251d119eca04a0ce55f194596710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798149
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869972}