Fix: CMake and GitHub Actions confusion about what is a (stable) tag #8919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
You can't have a release without things blowing up in your face :D
Description
Two mistakes:
I am not 100% sure about the last one, but what we have made no sense either way. This variable is used for
_openttd_newgrf_version
; I guess that means we pushed betas and RCs with the indication they were stable. So at the very least we have to push 1.11.0 as being stable. So this is not a regression for sure. But I have no clue if betas or RCs should be marked as "stable" or not.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.