Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: building on Raspberry Pi failed because of const vs constexpr #8924

Merged
merged 1 commit into from Apr 1, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Building OpenTTD on Raspberry Pi breaks because of this. Reported twice now, once via IRC and once via Discord.

Description

We had this problem before, but I cannot remember where/when/how. Either way, without this, we get undefined references to MAX_SIZE at industry_cmd.cpp:2219 and town_cmd.cpp:2247.

I am pretty sure last time we deduced the reasoning behind it and that it was solid. I just completely forgot what that reason is, but I am sure this is fine :D

After some digging: 9b800a9 here we had a similar issue with const vs constexpr when it was a static const as a member.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Apr 1, 2021
@TrueBrain TrueBrain merged commit 4d50165 into OpenTTD:master Apr 1, 2021
@TrueBrain TrueBrain deleted the raspberry branch April 1, 2021 17:39
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants