Fix: building on Raspberry Pi failed because of const vs constexpr #8924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Building OpenTTD on Raspberry Pi breaks because of this. Reported twice now, once via IRC and once via Discord.
Description
We had this problem before, but I cannot remember where/when/how. Either way, without this, we get
undefined references
toMAX_SIZE
atindustry_cmd.cpp:2219
andtown_cmd.cpp:2247
.I am pretty sure last time we deduced the reasoning behind it and that it was solid. I just completely forgot what that reason is, but I am sure this is fine :D
After some digging: 9b800a9 here we had a similar issue with
const
vsconstexpr
when it was a static const as a member.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.