Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct clipping of destination rects for filters when 3D transformed. #28413

Merged
merged 1 commit into from Apr 8, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

  • Make InverseMapQuadToLocalSpace flatten transform to avoid 3D clipping
    glitches.

    While cc::MathUtil::InverseMapQuadToLocalSpace was documented as
    requiring callers to flatten the transform, only one of the four
    existing callers did this. This changes it to flatten the transform
    internally.

    This fixes a bug where incorrect clipping rects were used in at least
    two of those three callers that were not flattening: the callers in
    SkiaRenderer::CalculateRPDQParams and
    GLRenderer::UpdateRPDQWithSkiaFilters. These callers were computing
    the minimal clip rect in local space (in a plane that might have a 3D
    transform) by transforming the clip rect (in the simple testcase, the
    window boundary), as a quad, into the local coordinate space,
    producing points that (with 3D) can have a nonzero Z components. This
    nonzero Z component was then dropped. However, the desired result was
    the point with a zero Z component in local space that would produce
    the correct X/Y position in device space with some arbitrary Z
    component in device space (that could then be dropped).

    This fixes the case tested in
    preserve3d-and-filter-no-perspective.html

  • Don't try clipping at all when the transform has perspective, since
    when there is perspective, there could be areas on the local surface
    that are visible even though they are outside the bounds of the quad
    that maps to the device's clip.

    This fixes the case tested in
    preserve3d-and-filter-with-perspective.html

Bug: 923766
Change-Id: I5fbc679300ca52446552a1f5d90160309073d687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2809095
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870500}

* Make InverseMapQuadToLocalSpace flatten transform to avoid 3D clipping
  glitches.

  While cc::MathUtil::InverseMapQuadToLocalSpace was documented as
  requiring callers to flatten the transform, only one of the four
  existing callers did this.  This changes it to flatten the transform
  internally.

  This fixes a bug where incorrect clipping rects were used in at least
  two of those three callers that were not flattening:  the callers in
  SkiaRenderer::CalculateRPDQParams and
  GLRenderer::UpdateRPDQWithSkiaFilters.  These callers were computing
  the minimal clip rect in local space (in a plane that might have a 3D
  transform) by transforming the clip rect (in the simple testcase, the
  window boundary), as a quad, into the local coordinate space,
  producing points that (with 3D) can have a nonzero Z components.  This
  nonzero Z component was then dropped.  However, the desired result was
  the point with a zero Z component in local space that would produce
  the correct X/Y position in device space with some arbitrary Z
  component in device space (that could then be dropped).

  This fixes the case tested in
  preserve3d-and-filter-no-perspective.html

* Don't try clipping at all when the transform has perspective, since
  when there is perspective, there could be areas on the local surface
  that are visible even though they are outside the bounds of the quad
  that maps to the device's clip.

  This fixes the case tested in
  preserve3d-and-filter-with-perspective.html

Bug: 923766
Change-Id: I5fbc679300ca52446552a1f5d90160309073d687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2809095
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870500}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6fe7ae1 into master Apr 8, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-420202ad5b branch April 8, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants