Fix #8922: Show vehicle window for single vehicle in shared order grouping #8926
Conversation
btzy
changed the title
|
Does this fix the issue? If a shared group window is opened, then the list size is reduced from 2+ to none, it will still crash, no? |
Hmm, I'll check that later tonight. However, if this was the case, then this bug would have been in OpenTTD for much longer than my PR for grouping by shared orders (and hence surprising that it was only discovered now). |
I've just tested and it no longer crashes: In the linked savegame, I bought a new vehicle and cloned the orders of vehicle 289 to it, then sold all vehicles in the depot (i.e. both of them). The shared orders window disappears as expected; no crashes. I believe the code that deletes the shared order window when there is only one vehicle left is this: Lines 2790 to 2793 in 799eb31 Presumably selling all vehicles in the depot will delete vehicles one-by-one, which is probably why it works. |
LordAro
added
the
backport requested
btzy
force-pushed
the
no-shared-order-of-1-vehicle
branch
from
8cc6a32
to
087ab7c
Compare
|
Reworded the commit message to conform to the style guide. |
src/group_gui.cpp
Outdated
| } | ||
| else { |
There was a problem hiding this comment.
Oh wait, codestyle - this and below should be on one line
btzy
force-pushed
the
no-shared-order-of-1-vehicle
branch
from
087ab7c
to
6a44914
Compare
LordAro
added
backported
Motivation / Problem
Fixes #8922 - shared order list could have only one vehicle, which leads to a crash later when that vehicle is deleted.
Description
When viewing by shared order groups, if a vehicle is not shared, don't open the shared order list (of just a single vehicle). Instead, open the vehicle window.
Limitations
None
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.