Fix #8922: Crash when selling last member of shared order group while window was open #8923
Conversation
|
@btzy You may be interested in taking a look |
LordAro
added
the
backport requested
…p while window was open
|
This doesn't seem to work on my Windows computer... with this commit, toggling the "Group By" dropdown (i.e. step 2 of #8922) only changes the number on the left of each row, but doesn't actually group anything. Without this commit, toggling the "Group By" dropdown works. (The bug in #8922 can be reproduced on my computer though.) |
|
I think this is not the right fix for the bug. The root cause seems to be due to the fact that the user can now have a "Shared orders of 1 vehicle" window opened. Previously, it was not possible to have such a situation because the shared orders window closes automatically when the user unshares the shared orders of 2 vehicles. |
|
I made PR #8926, that prevents opening a shared order list of just one vehicle. |
|
Closed in favour of #8926 |
LordAro
removed
the
backport requested
Motivation / Problem
#8922
Vehicle GUI window (while showing shared orders) could become empty while open (selling all vehicles in group)
Description
Close the window when shared order window's vehicle list becomes empty
Window was doing updates of internal state in OnPaint rather than OnInvalidateData which struck me as a bit weird, so moved stuff
Played around with it a bit (though not extensively), window still updates when it should, and doesn't crash
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.