Fix #8917: Release builds with asserts enabled #8925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Building release modes with assertions enabled was broken by #8916 & #8917
Description
Uses the WITH_ASSERTS macro definition instead, which is defined whenever assertions (OTTD's fake ones or the real ones) are enabled.
Limitations
Untested, except for locally & via https://github.com/LordAro/OpenTTD/actions/runs/709469793
Commit message needs rewording on squash to use the correct commit because I got the number wrong
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.