Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 0c9f9676c7cc
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 280f4c12e2e4
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 1, 2021

  1. haskellPackages.lsp-test: temporarily remove override

    This override currently breaks eval, but is probably still necessary in
    some form. However the change to fix it is non-trivial and not quickly
    actionable as hls-plugins-api currently is broken so the intended target
    of the override (haskell-language-server) can't be tested.
    
    Something in a similar spirit would be pinning lsp-test to 0.14.0.0
    which would however require to pick this patch from
    haskell-language-server master:
    
    haskell/haskell-language-server@6d1f1a5
    
    To me this sounds like a promising solution as it also adjusts to lsp
    1.2 which we now have in haskellPackages. Supposedly it also fixes some
    tests, so maybe we can remove the dontCheck.
    
    cc @maralorn
    sternenseemann committed Apr 1, 2021
    1
    Copy the full SHA
    280f4c1 View commit details
    Browse the repository at this point in the history