Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Title game for 1.11.0 release #8910

Merged
merged 1 commit into from Mar 30, 2021

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

Per the OpenTTD 1.11 Title Game Competition, a new title game was selected by the community for the 1.11.0 release.

Description

Replaced opntitle.dat with the winning savegame from Chrnan6710.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain changed the base branch from master to release/1.11 March 29, 2021 13:40
@TrueBrain TrueBrain changed the base branch from release/1.11 to master March 29, 2021 13:40
@TrueBrain
Copy link
Member

I think this PR should be against release/1.11 branch, as I believe we keep the title game in master to be this very old one (good for testing).

I tried to do that via GitHub, it had some hilarious results :D

I can pick this up tomorrow when I will backport all in master to the release branch anyway.

@2TallTyler 2TallTyler changed the base branch from master to release/1.11 March 29, 2021 13:51
@frosch123
Copy link
Member

In some years we added the winner to the credits window to the "Speical thanks" section (e.g. https://github.com/OpenTTD/OpenTTD/blob/release/1.8/src/misc_gui.cpp#L444 ).
Though we never were consistent with it :)

@TrueBrain TrueBrain merged commit 6c93f02 into OpenTTD:release/1.11 Mar 30, 2021
@2TallTyler 2TallTyler deleted the 1-11_title_game branch March 30, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants