Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: db4b9d8b96dd
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3920d3846da9
Choose a head ref
  • 5 commits
  • 6 files changed
  • 1 contributor

Commits on Mar 25, 2021

  1. Copy the full SHA
    4232944 View commit details
  2. fixup! orca: 3.38.2 → 40.0

    amaxine committed Mar 25, 2021
    Copy the full SHA
    64f5ca3 View commit details
  3. Copy the full SHA
    ffbb024 View commit details
  4. Copy the full SHA
    8c9e14f View commit details
  5. Copy the full SHA
    3920d38 View commit details
26 changes: 16 additions & 10 deletions pkgs/applications/misc/orca/fix-paths.patch
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
diff --git a/src/orca/debug.py b/src/orca/debug.py
index e79482ed4..cbf3a24ec 100644
--- a/src/orca/debug.py
+++ b/src/orca/debug.py
@@ -474,7 +474,7 @@
@@ -502,7 +502,7 @@ def traceit(frame, event, arg):
return traceit

def getOpenFDCount(pid):
@@ -9,7 +11,7 @@
procs = procs.decode('UTF-8').split('\n')
files = list(filter(lambda s: s and s[0] == 'f' and s[1:].isdigit(), procs))

@@ -482,7 +482,7 @@
@@ -510,7 +510,7 @@ def getOpenFDCount(pid):

def getCmdline(pid):
try:
@@ -18,7 +20,7 @@
cmdline = openFile.read()
openFile.close()
except:
@@ -492,7 +492,7 @@
@@ -520,7 +520,7 @@ def getCmdline(pid):
return cmdline

def pidOf(procName):
@@ -27,9 +29,11 @@
shell=True,
stdout=subprocess.PIPE).stdout
pids = openFile.read()
diff --git a/src/orca/orca.py b/src/orca/orca.py
index 2fe0a0bf2..087526556 100644
--- a/src/orca/orca.py
+++ b/src/orca/orca.py
@@ -239,7 +239,7 @@
@@ -285,7 +285,7 @@ def updateKeyMap(keyboardEvent):

def _setXmodmap(xkbmap):
"""Set the keyboard map using xkbcomp."""
@@ -38,7 +42,7 @@
stdin=subprocess.PIPE, stdout=None, stderr=None)
p.communicate(xkbmap)

@@ -297,7 +297,7 @@
@@ -363,7 +363,7 @@ def _storeXmodmap(keyList):
"""

global _originalXmodmap
@@ -47,7 +51,7 @@

def _restoreXmodmap(keyList=[]):
"""Restore the original xmodmap values for the keys in keyList.
@@ -309,7 +309,7 @@
@@ -375,7 +375,7 @@ def _restoreXmodmap(keyList=[]):

global _capsLockCleared
_capsLockCleared = False
@@ -56,9 +60,11 @@
stdin=subprocess.PIPE, stdout=None, stderr=None)
p.communicate(_originalXmodmap)

diff --git a/src/orca/orca_bin.py.in b/src/orca/orca_bin.py.in
index 8c9d40153..eec0d5437 100644
--- a/src/orca/orca_bin.py.in
+++ b/src/orca/orca_bin.py.in
@@ -59,7 +59,7 @@
@@ -62,7 +62,7 @@ class ListApps(argparse.Action):
name = "[DEAD]"

try:
@@ -67,12 +73,12 @@
except:
cmdline = '(exception encountered)'
else:
@@ -192,7 +192,7 @@
@@ -197,7 +197,7 @@ def inGraphicalDesktop():
def otherOrcas():
"""Returns the pid of any other instances of Orca owned by this user."""

- openFile = subprocess.Popen('pgrep -u %s orca' % os.getuid(),
+ openFile = subprocess.Popen('@pgrep@ -u %s orca' % os.getuid(),
- openFile = subprocess.Popen('pgrep -u %s -x orca' % os.getuid(),
+ openFile = subprocess.Popen('@pgrep@ -u %s -x orca' % os.getuid(),
shell=True,
stdout=subprocess.PIPE).stdout
pids = openFile.read()
10 changes: 4 additions & 6 deletions pkgs/data/fonts/cantarell-fonts/default.nix
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
{ lib, stdenv, fetchurl, meson, ninja, gettext, appstream-glib, gnome3 }:

let
stdenv.mkDerivation rec {
pname = "cantarell-fonts";
version = "0.301";
in stdenv.mkDerivation rec {
name = "${pname}-${version}";

src = fetchurl {
url = "mirror://gnome/sources/${pname}/${lib.versions.majorMinor version}/${name}.tar.xz";
sha256 = "10sycxscs9kzl451mhygyj2qj8qlny8pamskb86np7izq05dnd9x";
url = "mirror://gnome/sources/${pname}/${lib.versions.majorMinor version}/${pname}-${version}.tar.xz";
sha256 = "3d35db0ac03f9e6b0d5a53577591b714238985f4cfc31a0aa17f26cd74675e83";
};

nativeBuildInputs = [ meson ninja gettext appstream-glib ];
@@ -21,7 +19,7 @@ in stdenv.mkDerivation rec {

outputHashAlgo = "sha256";
outputHashMode = "recursive";
outputHash = "12ps2gjv1lmzbmkv16vgjmaahl3ayadpniyrx0z31sqn443r57hq";
outputHash = "1sczskw2kv3qy39i9mzw2lkl94a90bjgv5ln9acy5kh4gb2zmy7z";

passthru = {
updateScript = gnome3.updateScript {
7 changes: 2 additions & 5 deletions pkgs/desktops/gnome-3/apps/gnome-calendar/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{ lib, stdenv
, fetchurl
, fetchpatch
, meson
, ninja
, pkg-config
@@ -34,10 +33,8 @@ stdenv.mkDerivation rec {

patches = [
# https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/84
(fetchpatch {
url = "https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/84.patch";
sha256 = "czG3uIHl3tBnjDUvCOPm8IRp2o7yZYCb0/jWtv3uzIY=";
})
# A refactor has caused the PR patch to drift enough to need rebasing
./gtk_image_reset_crash.patch
];

passthru = {
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
diff --git a/src/gui/views/gcal-year-view.c b/src/gui/views/gcal-year-view.c
index ac32a8f9..532425c1 100644
--- a/src/gui/views/gcal-year-view.c
+++ b/src/gui/views/gcal-year-view.c
@@ -2158,7 +2158,11 @@ update_weather (GcalYearView *self)
if (!updated)
{
gtk_label_set_text (self->temp_label, "");
- gtk_image_clear (self->weather_icon);
+ /* FIXME: This should never be NULL, but it somehow is.
+ * https://gitlab.gnome.org/GNOME/gnome-calendar/issues/299
+ */
+ if (self->weather_icon != NULL)
+ gtk_image_clear (self->weather_icon);
}
}

4 changes: 2 additions & 2 deletions pkgs/desktops/gnome-3/core/gnome-font-viewer/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{ lib, stdenv, meson, ninja, gettext, fetchurl
, pkg-config, gtk3, glib, libxml2, gnome-desktop, adwaita-icon-theme
, pkg-config, gtk3, glib, libxml2, gnome-desktop, adwaita-icon-theme, libhandy
, wrapGAppsHook, gnome3, harfbuzz }:

stdenv.mkDerivation rec {
@@ -14,7 +14,7 @@ stdenv.mkDerivation rec {
doCheck = true;

nativeBuildInputs = [ meson ninja pkg-config gettext wrapGAppsHook libxml2 ];
buildInputs = [ gtk3 glib gnome-desktop adwaita-icon-theme harfbuzz ];
buildInputs = [ gtk3 glib gnome-desktop adwaita-icon-theme harfbuzz libhandy ];

# Do not run meson-postinstall.sh
preConfigure = "sed -i '2,$ d' meson-postinstall.sh";
9 changes: 1 addition & 8 deletions pkgs/desktops/gnome-3/core/gnome-session/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{ fetchurl, lib, stdenv, substituteAll, meson, ninja, pkg-config, gnome3, glib, gtk3, gsettings-desktop-schemas
, gnome-desktop, dbus, json-glib, libICE, xmlto, docbook_xsl, docbook_xml_dtd_412, python3
, libxslt, gettext, makeWrapper, systemd, xorg, epoxy, gnugrep, bash, gnome-session-ctl
, fetchpatch }:
, libxslt, gettext, makeWrapper, systemd, xorg, epoxy, gnugrep, bash, gnome-session-ctl }:

stdenv.mkDerivation rec {
pname = "gnome-session";
@@ -22,12 +21,6 @@ stdenv.mkDerivation rec {
grep = "${gnugrep}/bin/grep";
bash = "${bash}/bin/bash";
})
# Fixes 2 minute delay at poweroff.
# https://gitlab.gnome.org/GNOME/gnome-session/issues/74
(fetchpatch {
url = "https://gitlab.gnome.org/GNOME/gnome-session/-/commit/9de6e40f12e8878f524f8d429d85724c156a0517.diff";
sha256 = "19vrjdf7d6dfl7sqxvbc5h5lcgk1krgzg5rkssrdzd1h4ma6y8fz";
})
];

mesonFlags = [ "-Dsystemd=true" "-Dsystemd_session=default" ];