Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3920d3846da9
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 29d14fecce65
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 25, 2021

  1. Copy the full SHA
    f221c5f View commit details
  2. squash! gnome3.gnome-desktop: 40.rc → 40.0

    - use libxkbregistry to parse evdev rules files for us https://gitlab.gnome.org/GNOME/gnome-desktop/-/merge_requests/88
    jtojnar committed Mar 25, 2021
    Copy the full SHA
    9c530f9 View commit details
  3. squash! folks: 0.14.0 → 0.15.2

    - Had to add libgdata to fix:
    	[40/253] Compiling Vala source ../backends/eds/lib/edsf-persona-store.vala ../backends/eds/lib/edsf-persona.vala backends/eds/lib/namespace.vala folks/folks.vapi folks/folks-internal.vapila ../backends/ofono/org-ofono.vala folks/folks.vapi folks/folks-internal.vapi
    	FAILED: backends/eds/lib/libfolks-eds.so.26.0.0.p/edsf-persona-store.c backends/eds/lib/libfolks-eds.so.26.0.0.p/edsf-persona.c backends/eds/lib/libfolks-eds.so.26.0.0.p/namespace.c backends/eds/lib/folks/folks-eds.h backends/eds/lib/folks-eds.vapi backends/eds/lib/FolksEds-0.7.gir
    	valac -C --vapidir /build/folks-0.15.2/folks -D FOLKS_COMPILATION --pkg libxml-2.0 --pkg libedataserver-1.2 --pkg libebook-contacts-1.2 --pkg libebook-1.2 /build/folks-0.15.2/folks/folks-generics.vapi --pkg gee-0.8 --pkg gio-2.0 --pkg gmodule-2.0 --pkg gobject-2.0 /build/folks-0.15.2/folks/build-conf.vapi --color=always --directory backends/eds/lib/libfolks-eds.so.26.0.0.p --basedir ../backends/eds/lib --library folks-eds --header backends/eds/lib/folks/folks-eds.h --vapi ../folks-eds.vapi --gir ../FolksEds-0.7.gir --includedir folks ../backends/eds/lib/edsf-persona-store.vala ../backends/eds/lib/edsf-persona.vala backends/eds/lib/namespace.vala folks/folks.vapi folks/folks-internal.vapi
    	error: Package `libgdata' not found in specified Vala API directories or GObject-Introspection GIR directories
    	Compilation failed: 1 error(s), 0 warning(s)
    	[41/253] Compiling Vala source ../backends/ofono/ofono-backend-factory.vala ../backends/ofono/ofono-backend.vala ../backends/ofono/ofono-persona-store.vala ../backends/ofono/ofono-persona.vala ../backends/ofono/org-ofono.vala folks/folks.vapi folks/folks-internal.vapi
    	FAILED: backends/ofono/ofono.so.p/ofono-backend-factory.c backends/ofono/ofono.so.p/ofono-backend.c backends/ofono/ofono.so.p/ofono-persona-store.c backends/ofono/ofono.so.p/ofono-persona.c backends/ofono/ofono.so.p/org-ofono.c backends/ofono/ofono.h backends/ofono/ofono.vapi
    	valac -C --vapidir /build/folks-0.15.2/folks -D FOLKS_COMPILATION --pkg libedataserver-1.2 --pkg libebook-1.2 /build/folks-0.15.2/folks/folks-generics.vapi --pkg gee-0.8 --pkg gio-2.0 --pkg gmodule-2.0 --pkg gobject-2.0 /build/folks-0.15.2/folks/build-conf.vapi --color=always --directory backends/ofono/ofono.so.p --basedir ../backends/ofono --library ofono --header backends/ofono/ofono.h --vapi ../ofono.vapi ../backends/ofono/ofono-backend-factory.vala ../backends/ofono/ofono-backend.vala ../backends/ofono/ofono-persona-store.vala ../backends/ofono/ofono-persona.vala ../backends/ofono/org-ofono.vala folks/folks.vapi folks/folks-internal.vapi
    	error: Package `libgdata' not found in specified Vala API directories or GObject-Introspection GIR directories
    	Compilation failed: 1 error(s), 0 warning(s)
    jtojnar committed Mar 25, 2021
    Copy the full SHA
    183a5d5 View commit details
  4. Copy the full SHA
    29d14fe View commit details
71 changes: 56 additions & 15 deletions pkgs/desktops/gnome-3/core/gnome-desktop/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,28 @@
{ lib, stdenv, fetchurl, substituteAll, pkg-config, libxslt, ninja, gnome3, gtk3, glib
, gettext, libxml2, xkeyboard_config, isocodes, meson, wayland
, libseccomp, systemd, bubblewrap, gobject-introspection, gtk-doc, docbook_xsl, gsettings-desktop-schemas }:
{ lib
, stdenv
, fetchurl
, substituteAll
, pkg-config
, libxslt
, ninja
, gnome3
, gtk3
, glib
, gettext
, libxml2
, xkeyboard_config
, libxkbcommon
, isocodes
, meson
, wayland
, libseccomp
, systemd
, bubblewrap
, gobject-introspection
, gtk-doc
, docbook-xsl-nons
, gsettings-desktop-schemas
}:

stdenv.mkDerivation rec {
pname = "gnome-desktop";
@@ -13,17 +35,6 @@ stdenv.mkDerivation rec {
sha256 = "sha256-IKv9P4MeToCStVg5MRZh3HOyvxP8m+9xxKWkR12p7gQ=";
};

nativeBuildInputs = [
pkg-config meson ninja gettext libxslt libxml2 gobject-introspection
gtk-doc docbook_xsl glib
];
buildInputs = [
bubblewrap xkeyboard_config isocodes wayland
gtk3 glib libseccomp systemd
];

propagatedBuildInputs = [ gsettings-desktop-schemas ];

patches = [
(substituteAll {
src = ./bubblewrap-paths.patch;
@@ -32,6 +43,35 @@ stdenv.mkDerivation rec {
})
];

nativeBuildInputs = [
pkg-config
meson
ninja
gettext
libxslt
libxml2
gobject-introspection
gtk-doc
docbook-xsl-nons
glib
];

buildInputs = [
bubblewrap
xkeyboard_config
libxkbcommon # for xkbregistry
isocodes
wayland
gtk3
glib
libseccomp
systemd
];

propagatedBuildInputs = [
gsettings-desktop-schemas
];

mesonFlags = [
"-Dgtk_doc=true"
"-Ddesktop_docs=false"
@@ -46,7 +86,8 @@ stdenv.mkDerivation rec {

meta = with lib; {
description = "Library with common API for various GNOME modules";
license = with licenses; [ gpl2 lgpl2 ];
homepage = "https://gitlab.gnome.org/GNOME/gnome-desktop";
license = with licenses; [ gpl2Plus lgpl2Plus ];
platforms = platforms.linux;
maintainers = teams.gnome.members;
};
Original file line number Diff line number Diff line change
@@ -5,29 +5,10 @@ Date: Sun, 20 Sep 2020 14:46:59 -0400
Subject: [PATCH] fix paths

---
data/gnome-welcome-tour | 4 ++--
gnome-initial-setup/pages/keyboard/cc-input-chooser.c | 6 +++---
gnome-initial-setup/pages/timezone/tz.h | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/data/gnome-welcome-tour b/data/gnome-welcome-tour
index 51c9b59..68ab0c4 100755
--- a/data/gnome-welcome-tour
+++ b/data/gnome-welcome-tour
@@ -3,11 +3,11 @@
cfgdir=${XDG_CONFIG_DIR:-$HOME/.config}

# Don't do anything if gnome-tour isn't installed
-gnome_tour_path=$(which gnome-tour 2>/dev/null)
+gnome_tour_path="@gnome_tour@"
if test -z "${gnome_tour_path}"; then
rm -f $cfgdir/run-welcome-tour
exit
fi

-gnome-tour
+@gnome_tour@
rm -f $cfgdir/run-welcome-tour
diff --git a/gnome-initial-setup/pages/keyboard/cc-input-chooser.c b/gnome-initial-setup/pages/keyboard/cc-input-chooser.c
index 196abf6..613d0e5 100644
--- a/gnome-initial-setup/pages/keyboard/cc-input-chooser.c
16 changes: 7 additions & 9 deletions pkgs/desktops/gnome-3/core/gnome-initial-setup/default.nix
Original file line number Diff line number Diff line change
@@ -32,7 +32,6 @@
, tzdata
, libgnomekbd
, gsettings-desktop-schemas
, gnome-tour
}:

stdenv.mkDerivation rec {
@@ -44,6 +43,13 @@ stdenv.mkDerivation rec {
sha256 = "0vw9k4drslbxr9q0160v88zny3xx0rkfqks1lw9f23iq2i3cgq0l";
};

patches = [
(substituteAll {
src = ./0001-fix-paths.patch;
inherit tzdata libgnomekbd;
})
];

nativeBuildInputs = [
gettext
meson
@@ -78,14 +84,6 @@ stdenv.mkDerivation rec {
webkitgtk
];

patches = [
(substituteAll {
src = ./0001-fix-paths.patch;
inherit tzdata libgnomekbd;
gnome_tour = "${gnome-tour}/bin/gnome-tour";
})
];

mesonFlags = [
"-Dcheese=disabled"
"-Dibus=disabled"
12 changes: 2 additions & 10 deletions pkgs/development/libraries/folks/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{ fetchurl
, lib, stdenv
, pkg-config
, fetchpatch
, meson
, ninja
, glib
@@ -18,6 +17,7 @@
, dbus
, libgee
, evolution-data-server
, libgdata
, libsecret
, db
, python3
@@ -43,15 +43,6 @@ stdenv.mkDerivation rec {
sha256 = "08nirjax4m4g4ljr8ksq16wzmrvzq6myqh5rm0dw6pnijqk7nxzg";
};

patches = [
# Fix tests with e-d-s linked with libphonenumber support
# https://gitlab.gnome.org/GNOME/folks/merge_requests/40
(fetchpatch {
url = "https://gitlab.gnome.org/GNOME/folks/commit/6d443480a137f6a6ff345b21bf3cb31066eefbcd.patch";
sha256 = "D/Y2g12TT0qrcH+iJ2umu4Hmp0EJ3Hoedh0H3aWI+HY=";
})
];

mesonFlags = [
"-Ddocs=true"
"-Dtelepathy_backend=${lib.boolToString telepathySupport}"
@@ -75,6 +66,7 @@ stdenv.mkDerivation rec {
db
dbus-glib
evolution-data-server
libgdata # required for some backends transitively
libsecret
libsoup
libxml2