Avoid relying on vertical scrollbar placement in a couple of tests. #28425
Conversation
wpt-pr-bot
requested review from
AutomatedTester,
fantasai,
kojiishi,
plinss,
r12a and
upsuper
heycam
requested review from
dholbert
and removed request for
AutomatedTester,
upsuper,
fantasai,
kojiishi,
plinss and
r12a
| @@ -18,6 +18,8 @@ | |||
| { | |||
| height: 100%; | |||
| writing-mode: vertical-rl; | |||
| overflow: hidden; /* since test and reference would place scrollbars on | |||
There was a problem hiding this comment.
Maybe s/would place/might place/, throughout this commit?
(I don't think these styles do actually place scrollbars on opposite sides in any browsers right now; I think because the root scrollport has special behavior, in Firefox at least. I suspect that's changing in WebKit in https://bugs.webkit.org/show_bug.cgi?id=224224 though.)
There was a problem hiding this comment.
Now I am uncertain whether I do want to change root scrollbar placement in that bug. :-) If I do, I'll merge this PR. If not, I'll abandon it.
There was a problem hiding this comment.
OK so I think I do want to change the placement, since we already change the placement for horizontal RTL documents.
There was a problem hiding this comment.
Yup, I noticed that. Makes sense. thanks!
These two tests can end up placing their root vertical scrollbars on different sides of the window, due to the use of different writing modes. They aren't specifically testing anything to do with scrollbars, so we turn them off.
heycam
force-pushed
the
vertical-scrollbar-pos
branch
from
05d1e66
to
145cbe9
Compare
|
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
These two tests can end up placing their root vertical scrollbars on different sides of the window, due to the use of different writing modes. They aren't specifically testing anything to do with scrollbars, so we turn them off.