[Gecko Bug 1699866] Make HTMLEditor::SplitAncestorStyledInlineElementsAt return "not handled" if there is no splitable element at given point
#28423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndled" if there is no splitable element at given point When given point is **in** a void element, e.g., this can be when JS inserts nodes into a void element like `<meta>`, `HTMLEditor::SplitNodeDeepWithTransaction` may return "not handled" state. So, it's possible case, we shouldn't assert the case. This patch adds both WPT and crashtests because I couldn't reproduce it with WPT's simpler API use. Differential Revision: https://phabricator.services.mozilla.com/D111231 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1699866 gecko-commit: 30f71808849762b4fb1de1a6ddd7effcaa088f12 gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given point is in a void element, e.g., this can be when JS inserts
nodes into a void element like
<meta>,HTMLEditor::SplitNodeDeepWithTransactionmay return "not handled" state.So, it's possible case, we shouldn't assert the case.
This patch adds both WPT and crashtests because I couldn't reproduce it
with WPT's simpler API use.
Differential Revision: https://phabricator.services.mozilla.com/D111231
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1699866
gecko-commit: 30f71808849762b4fb1de1a6ddd7effcaa088f12
gecko-reviewers: m_kato