Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names with escaped brackets do not match #45

Closed
christian-lanius opened this issue Apr 2, 2021 · 1 comment
Closed

Names with escaped brackets do not match #45

christian-lanius opened this issue Apr 2, 2021 · 1 comment
Assignees
@christian-lanius @kgugala
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@christian-lanius
Copy link
Contributor

christian-lanius commented Apr 2, 2021 •
edited

Hi all,
I have found another issue regarding matching of more obscure valid sdf. Valid names in verilog netlists include names such as TESTENV/reset_synchronizer_genblk1\[0\]\.ff_1_reg/RESET. The grammar to match the name does not match to this, instead returning an error that the character "" is an invalid name. I will provide a pull request for this issue soon.
@issuelabeler issuelabeler bot added the invalid This doesn't seem right label Apr 2, 2021
@litghost litghost added bug Something isn't working and removed invalid This doesn't seem right labels Apr 2, 2021
@issuelabeler issuelabeler bot added the invalid This doesn't seem right label Apr 2, 2021
christian-lanius added a commit to christian-lanius/python-sdf-timing that referenced this issue Apr 2, 2021
@christian-lanius
allow backslash in string, fixes issue chipsalliance#45
476bfad 
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
@christian-lanius christian-lanius mentioned this issue Apr 2, 2021
Merged
@christian-lanius
Copy link
Contributor Author

Regarding the failing pipeline, this appears to be an issue specifically with building for 3.5. According to the pytest git repo, support for python 3.5 has been dropped: pytest-dev/pytest#7808, this is most likely related to that.

christian-lanius added a commit to christian-lanius/python-sdf-timing that referenced this issue Apr 6, 2021
@christian-lanius
allow backslash in string, fixes issue chipsalliance#45
b167e27 
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
christian-lanius added a commit to christian-lanius/python-sdf-timing that referenced this issue Apr 6, 2021
@christian-lanius
allow backslash in string, fixes issue chipsalliance#45
0518ed0 
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
kgugala added a commit that referenced this issue Apr 6, 2021
@kgugala
Merge pull request #46 from christian-lanius/escaped_character_fix
5b9dc79 
allow backslash in string, fixes issue #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christian-lanius christian-lanius

@kgugala kgugala

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@litghost @christian-lanius @kgugala