Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove css-transforms tests of units in svg transform attributes #28356

Merged
merged 1 commit into from Apr 6, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 2, 2021

This patch removes WPT tests that were covering units, following the css
transform syntax, in the svg transform attribute. These tests were
correct when added but this is is not supported in any engine and
w3c/csswg-drafts#2623 resolved to not use
CSS parsing rules for the SVG transform attribute. The spec for this is:
https://www.w3.org/TR/css-transforms-1/#svg-syntax

In addition to removing tests, the following tests have been modified to
not rely on this behavior:
translate/svg-translate-049.html
translate/svg-translate-050.html
translate/svg-translate-051.html
translate/svg-translate-052.html
translate/svg-translate-053.html
translate/svg-translate-054.html
translate/svg-translate-055.html
translate/svg-translate-multiple-001.html
translate-and-transform-attribute-in-svg.html

The following tests have been added to ensure units do not apply:
skewX/svg-skewx-with-units.html
skewY/svg-skewy-with-units.html
translate/svg-translate-with-units.html

Bug: 1194735
Change-Id: I157b51826fdd8ba82bc550089876ad08d73cf970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2801330
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869584}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This patch removes WPT tests that were covering units, following the css
transform syntax, in the svg transform attribute. These tests were
correct when added but this is is not supported in any engine and
w3c/csswg-drafts#2623 resolved to not use
CSS parsing rules for the SVG transform attribute. The spec for this is:
https://www.w3.org/TR/css-transforms-1/#svg-syntax

In addition to removing tests, the following tests have been modified to
not rely on this behavior:
  translate/svg-translate-049.html
  translate/svg-translate-050.html
  translate/svg-translate-051.html
  translate/svg-translate-052.html
  translate/svg-translate-053.html
  translate/svg-translate-054.html
  translate/svg-translate-055.html
  translate/svg-translate-multiple-001.html
  translate-and-transform-attribute-in-svg.html

The following tests have been added to ensure units do not apply:
  skewX/svg-skewx-with-units.html
  skewY/svg-skewy-with-units.html
  translate/svg-translate-with-units.html

Bug: 1194735
Change-Id: I157b51826fdd8ba82bc550089876ad08d73cf970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2801330
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869584}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 32000e2 into master Apr 6, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2801330 branch April 6, 2021 17:56
stephenmcgruer added a commit to Ecosystem-Infra/wpt-results-analysis that referenced this pull request Apr 14, 2021
stephenmcgruer added a commit to Ecosystem-Infra/wpt-results-analysis that referenced this pull request Apr 21, 2021
…PT (#45)

* [compat2021] Remove css-transforms-tests.txt that were removed from WPT

See web-platform-tests/wpt#28356

* Add two tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants