Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum initial loan amount does not match Game Settings #8932

Open
TedB86 opened this issue Apr 2, 2021 · 15 comments
Open

Maximum initial loan amount does not match Game Settings #8932

TedB86 opened this issue Apr 2, 2021 · 15 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! good first issue Good for newcomers

Comments

@TedB86
Copy link

TedB86 commented Apr 2, 2021

Version of OpenTTD

1.11.0 (On Steam)

Expected result

Maximum initial loan that is able to be taken should be limited to the amount in settings. Should be restricted with error message.

Actual result

Player is able to Loan money up to an amount larger than in Game Settings.

Steps to reproduce

  1. Start new game
  2. Check "Maximum Initial Loan" value in Game Settings (e.g £300,000)
  3. Use the Finances screen to borrow money. Once additional borrowing amount of £300,000 is reached (on top of the initial £150,000), the game will allow you to borrow more, in the screenshot a value of £550,000 is possible (Should be £150,000 + £300,000 = £450,000?)

OpenTTD_Loan

@LordAro
Copy link
Member

LordAro commented Apr 2, 2021

This is a known problem. After inflation got "readjusted" (#7589), certain values no longer make sense - the settings window can't know what year your game starts at, so can't apply inflation to it sanely.

Likely the solution here is to change the setting to be "percentage of initial money" (200%, 300%, etc) - this was also previously mentioned in #8627

(Please fill out the template, it's there for a reason!)

@TedB86
Copy link
Author

TedB86 commented Apr 2, 2021

Apologies, template added (GitHub newbie, here).

Thanks for the comment, this does seem to be related to #8627, I didn't notice it prior to 1.11.0.

@2TallTyler 2TallTyler added enhancement Issue would be a good enhancement; we accept Pull Requests! good first issue Good for newcomers labels Oct 19, 2022
@ShlokJswl
Copy link

Hi If this issue still persists can you please assign this to me? I would like to work on this.

@LordAro
Copy link
Member

LordAro commented Jan 25, 2023

We don't generally assign issues. If you want to work on it, feel free to do so :)

@ShlokJswl
Copy link

We don't generally assign issues. If you want to work on it, feel free to do so :)

@LordAro thanks for the reply, are there any documentation of the game available?

@ShlokJswl
Copy link

ShlokJswl commented Feb 5, 2023

@LordAro Hi, upon installing the game, the config file is not present in the supposed path, am I missing anything?
Any other way to get the file?

@glx22
Copy link
Contributor

glx22 commented Feb 6, 2023

Did you start it at least once ?

@ShlokJswl
Copy link

ShlokJswl commented Feb 6, 2023

Hi @glx22 Yes I did, it gave me a popup saying game does not have graphics would you like to download, I clicked on yes and I guess the game crashed as I have a crash dump created in the OpenTTD folder in documents directory.

EDIT: Kept the OpenGFX package in the baseset directory and it's working now, let me know if the earlier crash dump is of any interest to you.

@ShlokJswl
Copy link

ShlokJswl commented Feb 6, 2023

Hi @glx22 While trying to reproduce the issue in version 13.0 I could not borrow more money than the set Max loan limit. I followed the steps mentioned above, am I doing something wrong or is this issue fixed in this version?
Screenshot 2023-02-06 155405

@ShlokJswl
Copy link

Hi can anyone give me some idea about whether this issue is fixed or am I not following the correct steps? Is there any other way to reach you? Any slack/discord channel?

@rubidium42
Copy link
Contributor

I think the "Inflation" setting is off for your game.
For other means of reaching someone, take a look at https://www.openttd.org/contact

@ShlokJswl
Copy link

Thanks @rubidium42, I have started working on this issue and will get back to you with some substantial work in a couple of days.

@Eddi-z
Copy link
Contributor

Eddi-z commented Apr 15, 2023

When trying to "fix" this bug, keep in mind that the maximum (and initial) loan amount is intentionally scaled with inflation, the "bug" is just the phrasing of the setting, which doesn't make sense anymore with the new inflation model, which simulates inflation before the game start year

@ShlokJswl
Copy link

When trying to "fix" this bug, keep in mind that the maximum (and initial) loan amount is intentionally scaled with inflation, the "bug" is just the phrasing of the setting, which doesn't make sense anymore with the new inflation model, which simulates inflation before the game start year

In your opinion does it make any sense to work on this issue then?

@ShlokJswl
Copy link

Hi, Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants