Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed scroll start and end offset properties of ScrollTimeline #28358

Merged
merged 1 commit into from Apr 22, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 2, 2021

Made modifications spec'ed in
w3c/csswg-drafts#5803:

  • Removed startOffset and endOffset attributes.
  • Updated procedures based on spec changes, including allowing single
    scroll offset of 'auto'.

Bug: 1094014
Change-Id: Id08c9ce1818bd561ac291ca3e1f99c22dbb15674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2801290
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874955}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2801290 branch 5 times, most recently from 0dcf492 to 48a3ca4 Compare April 21, 2021 23:31
Made modifications spec'ed in
w3c/csswg-drafts#5803:
- Removed startOffset and endOffset attributes.
- Updated procedures based on spec changes, including allowing single
scroll offset of 'auto'.

Bug: 1094014
Change-Id: Id08c9ce1818bd561ac291ca3e1f99c22dbb15674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2801290
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874955}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants