Remove blob #8931
Merged
Remove blob #8931
+95
−669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
reviewed
Apr 2, 2021
frosch123
reviewed
Apr 2, 2021
frosch123
reviewed
Apr 2, 2021
frosch123
reviewed
Apr 2, 2021
| CStrA out; | ||
| out.Format("0x%04X (%d, %d)", tile, TileX(tile), TileY(tile)); | ||
| return out.Transfer(); | ||
| std::stringstream ss; |
There was a problem hiding this comment.
personally I always do "char buf[32]" and "seprintf" in such cases.
But now you already put in the effort to find those weird stream modifiers :p
There was a problem hiding this comment.
Depends how much we care about the extra overhead of sstream/iomanip includes
frosch123
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Unfixable GCC warnings when linking with LTO due to "optimised" code mixing heap & stack objects (it can't ever do this, but GCC warns all the same)
attempt to free a non-heap object 'hdrEmpty' [-Wfree-nonheap-object]Description
Blob/CBlobT/CStrA is some weird code (mostly used by YAPF desync dump output) with auto-lifetime managed container objects.
Luckily, the STL exists and we can use std::string/std::vector for the same purposes.
Limitations
This is basically a 1-1 translation and the code is still real ugly.
Converting "advanced" printf commands (
0x%04X) to iostream-based code is real ugly.std::formatwould make it nicer, but that requires C++20 :)Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.