Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more light dismiss tests #28416

Merged
merged 1 commit into from Apr 9, 2021
Merged

Add more light dismiss tests #28416

merged 1 commit into from Apr 9, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

The new three all fail - they need to be implemented for
<popup>.

Bug: 1168738
Change-Id: Iecb6cb4be9cc131fb3e9d938ee24db26fa67ae87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812760
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870530}

The new three all fail - they need to be implemented for
<popup>.

Bug: 1168738
Change-Id: Iecb6cb4be9cc131fb3e9d938ee24db26fa67ae87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812760
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870530}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@jpchase
Copy link

jpchase commented Apr 9, 2021

The new tests are flaky on Chrome dev:

Unstable Results

Test Subtest Results Messages
/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss.tentative.html Clicking outside a popup will dismiss the popup FAIL: 3/10, PASS: 7/10 assert_equals: expected 1 but got 0
/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss.tentative.html Clicking inside a popup does not close that popup FAIL: 3/10, PASS: 7/10 assert_equals: expected 0 but got 1

@jpchase
Copy link

jpchase commented Apr 9, 2021

Filed crbug.com/1197633.

@jpchase jpchase merged commit 4fc8171 into master Apr 9, 2021
@jpchase jpchase deleted the chromium-export-4da4ec8066 branch April 9, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants