Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong language loaded on first game start #8973

Closed
WimLeflere opened this issue Apr 8, 2021 · 2 comments
Closed

Wrong language loaded on first game start #8973

WimLeflere opened this issue Apr 8, 2021 · 2 comments

Comments

@WimLeflere
Copy link
Contributor

Version of OpenTTD

Own Windows build of master 130a052

Expected result

My Windows display language and keyboard are configured as 'English (United States)'.
I was expecting that the game would start in English.

Actual result

The game started in Dutch.
Maybe because my 'Regional format' (date & time format) is configured as 'Dutch (Belgium)'.

Also tested with 'French (Belgium)' and the game starts in French.

Steps to reproduce

  1. delete the value for language in openttd.cfg
  2. change 'Regional format' in Windows settings
  3. start the game
@WimLeflere
Copy link
Contributor Author

I'm working on a fix which uses GetUserDefaultUILanguage() to determine the Windows display language.

WimLeflere added a commit to WimLeflere/OpenTTD that referenced this issue Apr 8, 2021
@WimLeflere
Change: [win32] Use user UI language instead of date/time locale for …
b708acc 
…initial language selection (OpenTTD#8973)
@WimLeflere WimLeflere mentioned this issue Apr 8, 2021
Merged
WimLeflere added a commit to WimLeflere/OpenTTD that referenced this issue Apr 9, 2021
@WimLeflere
Change: [win32] Use user UI language instead of date/time locale for …
9d31451 
…initial language selection (OpenTTD#8973)

Convert language ID to locale ID to have the correct type for GetLocaleInfo
michicc pushed a commit that referenced this issue Apr 9, 2021
@WimLeflere
Change: [win32] Use user UI language for initial language selection (#…
5233fd2 
…8973) (#8974)
@TrueBrain
Copy link
Member

Fixed by #8973 (was missing "Fixes .. " tag)

LordAro pushed a commit to LordAro/OpenTTD that referenced this issue Apr 17, 2021
@WimLeflere @LordAro
Change: [win32] Use user UI language for initial language selection (O…
a558b9d 
…penTTD#8973) (OpenTTD#8974)
LordAro pushed a commit that referenced this issue Apr 18, 2021
@WimLeflere @LordAro
Change: [win32] Use user UI language for initial language selection (#…
9d233bb 
…8973) (#8974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrueBrain @WimLeflere