Volume controls in Game Options window #8943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
You can't control sound and music volume from the main menu.
Several new players complain about being blasted by sound when they start the game for the first time.
Description
Add volume controls to the Game Options window. The controls remain in the Jukebox window too, the controls are synced between both windows.
Also change the default volume of sound and music from "max" to something less. (The default of Transport Tycoon wasn't max.)
2021-04-04_11-20-33.mp4
Limitations
Whether to change the default volume settings is probably up to discussion.
Arguably the volume slider control should be implemented as a proper widget instead of the slightly hacky pair of functions done here.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.