New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test 'current environment settings object' for Worker() URL parsing and COEP report #28313
Test 'current environment settings object' for Worker() URL parsing and COEP report #28313
Conversation
I don't think it's possible to test the difference between "current environment settings object" and "relevant environment settings object" when it's a constructor, since you can't do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a multi-globals perspective, with a potential small simplification.
It would be ideal to get @d0iasm's review as well from a worker/COEP reporting perspective.
workers/multi-globals/entry.html
Outdated
<script> | ||
async_test((t) => { | ||
onload = () => { | ||
document.getElementById('button').click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indirection through the button click shouldn't be necessary. Compare to e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Sorry for being late. LGTM! Thank you for adding the tests. |
See whatwg/html#6525
cc @d0iasm