Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 'current environment settings object' for Worker() URL parsing and COEP report #28313

Merged

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Mar 31, 2021

@zcorpan
Copy link
Member Author

zcorpan commented Mar 31, 2021

I don't think it's possible to test the difference between "current environment settings object" and "relevant environment settings object" when it's a constructor, since you can't do foo.call(otherWindow.foo) to invoke the constructor. It's possible I'm missing something though.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a multi-globals perspective, with a potential small simplification.

It would be ideal to get @d0iasm's review as well from a worker/COEP reporting perspective.

<script>
async_test((t) => {
onload = () => {
document.getElementById('button').click();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@d0iasm
Copy link
Contributor

d0iasm commented Apr 7, 2021

Sorry for being late. LGTM! Thank you for adding the tests.

@zcorpan zcorpan merged commit 25dba84 into master Apr 7, 2021
@zcorpan zcorpan deleted the bocoup/worker-coep-report-current-environment-settings branch April 7, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants