BatteryService: Use systemsettings for battery information. #19
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentRevest
approved these changes
Apr 6, 2021
MagneFire
force-pushed
the
gatesgarth_v2
branch
from
48c0848 to
5371d8b
Compare
Merged
|
All this doesn't actually depend on the statefs removal PR (AsteroidOS/meta-asteroid#61). This does however require a change in dependencies, I will instead adjust AsteroidOS/meta-asteroid#65 to use the correct dependency, once that one is merged we can merge this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. more work towards deprecating
statefs.This implementation is basically taken from buteo-mtp: https://git.sailfishos.org/mer-core/buteo-mtp/commit/d70475180d3b67c75f5c1fb195c926a646c02ca5
Need to do some more testing with lipstick (https://github.com/MagneFire/lipstick/commits/gatesgarth_v2), otherwise everything seems to work.
I'll add a WIP meta-asteroid PR when everything is in a more usable state.
For now the changes in meta-asteroid are: