[credentialless]: Fix WPT reliability. #28382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 6, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2807579
branch
from
3ec5634
to
3d69ced
Compare
It sounds like some server of the official web-test-platform runner can drop some requests when too many are sent in parallel. This patch ensures both send/receive function retry as long as there is an error. We also limit the number of concurrent access to the fetch API to one per document. Bug: 1196073 Change-Id: I2c2ef6c2b7c6d7bbeeea2709f1c6bacbcb081419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2807579 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#869558}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2807579
branch
from
3d69ced
to
f70810f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sounds like some server of the official web-test-platform runner can
drop some requests when too many are sent in parallel.
This patch ensures both send/receive function retry as long as there is
an error. We also limit the number of concurrent access to the fetch API
to one per document.
Bug: 1196073
Change-Id: I2c2ef6c2b7c6d7bbeeea2709f1c6bacbcb081419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2807579
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869558}