[composite-bgcolor-animation] Ensure repaint #28387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 6, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2795992
branch
4 times, most recently
from
8e75b73
to
3e3ef90
Compare
Currently we rely on HasCurrentBackgroundColorAnimation() != other.HasCurrentBackgroundColorAnimation() in the StyleDifference to trigger a repaint for an element with background color animation. But this isn't enough, specifically we could have a composited bgcolor animation attached to an element at Nth frame, but have a non-compositable animation attached to this element at (N+1)th frame. Some notes about this CL is here: https://docs.google.com/document/d/1MUjde9fUXsfIJ7l-7Wwl922Xj6HAL9FSWNyzL1JITz4/edit Bug: 1184832 Change-Id: I8b6d0ae366c03e1cd64f75685b2127c664b75939
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2795992
branch
from
3e3ef90
to
328033c
Compare
|
Close this PR because the Chromium CL does not have exportable changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we rely on HasCurrentBackgroundColorAnimation() !=
other.HasCurrentBackgroundColorAnimation() in the StyleDifference
to trigger a repaint for an element with background color animation.
But this isn't enough, specifically we could have a composited
bgcolor animation attached to an element at Nth frame, but have
a non-compositable animation attached to this element at (N+1)th
frame.
Some notes about this CL is here:
https://docs.google.com/document/d/1MUjde9fUXsfIJ7l-7Wwl922Xj6HAL9FSWNyzL1JITz4/edit
Bug: 1184832
Change-Id: I8b6d0ae366c03e1cd64f75685b2127c664b75939
Reviewed-on: https://chromium-review.googlesource.com/2795992
WPT-Export-Revision: df0942d9635f1c91955ae079778665b225591ae5