Call ChildrenRemoved() in base class first #28392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed style recalc root has to be updated in ContainerNode::ChildrenRemoved() before we can start marking style dirty for the object/plugin. Otherwise the style traversal root code triggers a DCHECK. Bug: 1195633 Change-Id: I2e41a66ba869a23e1d3f246d3e1ba4d862709f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2807619 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#869908}
wpt-pr-bot
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed style recalc root has to be updated in
ContainerNode::ChildrenRemoved() before we can start marking style dirty
for the object/plugin. Otherwise the style traversal root code triggers
a DCHECK.
Bug: 1195633
Change-Id: I2e41a66ba869a23e1d3f246d3e1ba4d862709f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2807619
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869908}