Revert "Expand bounds of mask layer by 1 pixel" #28391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c0d54d1aa9b348261e4e3b550ad02e746229b9ac. Reason for revert: The CL caused crbug.com/1196148. Original change's description: > Expand bounds of mask layer by 1 pixel > > This is similar to crrev.com/c/2786129 which is for synthesized clip > mask layer, to ensure the mask fully covers the masked contents > regardless of computation errors in later stages. > > To make that work, we also need to decomposite the MaskClip on the mask > layer, otherwise the expanded pixels would be clipped off and would > have no effect. > > Bug: 1171601 > Change-Id: I3198f228de1a0aa8baf2b8ed3c670ceabdeb57a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787695 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#869079} Bug: 1171601, 1196148 Change-Id: I31d960ddee5e2b7bb34cbfd676e8e29718324fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2809522 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#869821}
wpt-pr-bot
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c0d54d1aa9b348261e4e3b550ad02e746229b9ac.
Reason for revert: The CL caused crbug.com/1196148.
Original change's description:
Bug: 1171601, 1196148
Change-Id: I31d960ddee5e2b7bb34cbfd676e8e29718324fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2809522
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#869821}