Add options for adding ContextAttributes when calling getContext #28268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 28, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2788735
branch
2 times, most recently
from
6d6a5d0
to
e7b1414
Compare
Adding a new tag "attributes" in Canvas Template file, so that users
can do getContext('2d', attributes). I also added a test uses this
function in this cl.
Bug: 1178707
Change-Id: I020f7d83831391895b8b937e623f30f28dbcbc5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2788735
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869392}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2788735
branch
from
e7b1414
to
62d6f13
Compare
|
The changed tests are flaky on both Chrome Dev and Firefox nightly (this could be new or pre-existing flakes). Chrome Dev Unstable results
Firefox Unstable results
|
|
Filed crbug.com/1197669. I'll force merge this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new tag "attributes" in Canvas Template file, so that users
can do getContext('2d', attributes). I also added a test uses this
function in this cl.
Bug: 1178707
Change-Id: I020f7d83831391895b8b937e623f30f28dbcbc5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2788735
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869392}