Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8565: Stopped road vehicle displays a speed different than 0 #8901

Merged
merged 1 commit into from Mar 30, 2021
Merged

Fix #8565: Stopped road vehicle displays a speed different than 0 #8901

merged 1 commit into from Mar 30, 2021

Conversation

pro452
Copy link
Contributor

@pro452 pro452 commented Mar 28, 2021

Motivation / Problem

Vehicle now shows speed of 0 when stopped.

Description

Update the vehicle speed when stopped

Limitations

Will need to check if happen with vehicles other than road vehicles.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Mar 28, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks very much!

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Mar 28, 2021
@TrueBrain TrueBrain merged commit 49c89cb into OpenTTD:master Mar 30, 2021
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Mar 30, 2021
@pro452 @TrueBrain
Fix OpenTTD#8565: Stopped road vehicle displays a speed different tha…
52fecd9 
…n 0 (OpenTTD#8901)
@TrueBrain
Copy link
Member

Just in time to be part of 1.11.0 \o/

Awesome :D

TrueBrain pushed a commit that referenced this pull request Apr 1, 2021
@pro452 @TrueBrain
Fix #8565: Stopped road vehicle displays a speed different than 0 (#8901
b36b1a8 
)
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 1, 2021
@pro452 pro452 deleted the Fix_#8565 branch April 2, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pro452 @TrueBrain @LordAro