Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to sort BaNaNaS content in-game by upload date yet #8903

Closed
James103 opened this issue Mar 28, 2021 · 2 comments
Closed

Unable to sort BaNaNaS content in-game by upload date yet #8903

James103 opened this issue Mar 28, 2021 · 2 comments

Comments

@James103
Copy link
Contributor

Version of OpenTTD

After merge of PR #8902 and PR OpenTTD/bananas-server#43

Expected result

You should be able to sort the BaNaNaS content based on when it is uploaded, allowing you to see what the newest BaNaNaS additions are.

Actual result

You are unable to sort the BaNaNaS content based on when it is uploaded. Currently, in order to find out what the newest additions to BaNaNaS are since a given date, you first have to download every single content item from BaNaNaS on that particular date, which requires OpenTTD to restart several times, can take several hours, and uses several GiB of CDN bandwidth.

Once #8902 and OpenTTD/bananas-server#43 have been merged, OpenTTD will now have the necessary data (upload date/time) to be able to sort the BaNaNaS content based on upload date, which is why I'm opening this issue.

I suggest that the new button be labelled "Upload date" or just "Date".

Steps to reproduce

  1. Use "Check Online Content".
  2. Attempt to sort by date uploaded. There is no such option available yet.
@nielsmh
Copy link
Contributor

nielsmh commented Mar 28, 2021

That's not a bug, and there is also already PR #8902 opened to implement this.

@nielsmh nielsmh closed this as completed Mar 28, 2021
@perezdidac
Copy link
Contributor

Hi! I believe @James103 referred to using the upload date field for sorting, which I was going to work on anyway, but my first PRs were in place to send/receive the upload date first, and was going to work on a separate PR to actually use it to sort.

@perezdidac perezdidac mentioned this issue Apr 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nielsmh @perezdidac @James103