Replace IConsolePrint*(F)( calls with specific console level calls #8894
Conversation
|
Ah yes, I hadn't considered that va_args are a pain to deal with. ...perhaps C++ variadic templates would be nicer? Quickly getting more complicated though, can certainly understand if don't want to go with that |
I think that using variadic templates requires moving the now-templated function definitions into the console_func.h header file. The methods refer to the ClientSettings _settings_client that is defined in settings.cpp and not "exported". I don't think we want to make that change. I've never done C++ development before and this is new to me. |
|
@LordAro I force-pushed an cannot see the "requested changes". I believe I addressed all of them. I'm used to using another system that does not "lose" comments when a force push occurs. |
|
I'm not really sure about this PR, as is. It adds a lot of extra functions, and doesn't even fix the original issue (inconsistent message prefix) In its current form, the various Then all of the |
|
I would have appreciated it if you would have mentioned this up front, almost two weeks ago, instead of now. I do not see any mention of the " inconsistent message prefix" problem in the related issue's comments. If something is undesirable or unwanted please mention this up front. At this time, I do not plan to put any more effort into this PR. Feel free to drop it or improve it. I may take a look at it again in a week or two depending on my priorities. |
Motivation / Problem
Implements changes mentioned in #8853 with a few added methods for consistency
Description
Added IConsoleF( and IConsole( methods to make console logging more consistent
Updated calls to IConsoleF( and IConsole( to new methods
Limitations
Formatting of messages with log level text was inconsistent in the existing code. I chose to not modify the current output contents to prefix with the log level. In some places the logged level did not match the apparent severity of the message. I did not update the function calls to match what I though the apparent severity was.
I chose to have the IConsoleDebugF( method signature match the other IConsole%LogLevel%F methods instead of the IConsoleDebug method.
There is at least one place where I did not update the IConsolePrint(CC_WARNING method to use IConsoleWarning( as the message may not have been output depending on the GUI developer setting.
Can be squashed to one commit and reworded if requested.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.