Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Suppress warnings when asserts are disabled #8917

Merged
merged 1 commit into from Apr 1, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Similar to #8916, but with more.

This should give a clean build log for release builds too .. I hope :D

Description

Some parts could be rewritten to be nicer, this for sure was the lazy approach. But some code is just a bit horrible in terms of assert usage. Too close to a release to really worry about this.

Tested with both GCC 9 and CLang 10, both Debug and Release, all with asserts disabled.

It should make no functional changes .. but .. please look at this carefully :D

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Apr 1, 2021
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrueBrain TrueBrain merged commit fece1c5 into OpenTTD:master Apr 1, 2021
@TrueBrain TrueBrain deleted the fix-no-assert branch April 1, 2021 09:16
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this pull request Apr 1, 2021
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants