Codechange: Suppress warnings when asserts are disabled #8917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Similar to #8916, but with more.
This should give a clean build log for release builds too .. I hope :D
Description
Some parts could be rewritten to be nicer, this for sure was the lazy approach. But some code is just a bit horrible in terms of
assert
usage. Too close to a release to really worry about this.Tested with both GCC 9 and CLang 10, both Debug and Release, all with asserts disabled.
It should make no functional changes .. but .. please look at this carefully :D
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.