Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Credentialless] WPT for redirect. #28214

Merged
merged 1 commit into from Apr 6, 2021
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 24, 2021

Check whether a COEP:cors-or-credentialless document should omit credentials
after a redirect.

Relevant discussion/doc:
https://docs.google.com/document/d/1U1pDzS_WJpfkq6QqOeqgmXmba_I4tIbUR-5C1AHzI9o/edit#heading=h.t5dgh0h3jo8kThe correct expectations is still a big question.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1175099
Change-Id: I8bb3f61177aee364ec438c5e05a3e1c5dc0d5148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785040
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868488}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title credentialless: WPT for redirect. [Credentialless] WPT for redirect. Mar 24, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2785040 branch 2 times, most recently from 5616582 to 3564209 Compare March 31, 2021 12:53
Check whether a COEP:cors-or-credentialless document should omit credentials
after a redirect.

Relevant discussion/doc:
https://docs.google.com/document/d/1U1pDzS_WJpfkq6QqOeqgmXmba_I4tIbUR-5C1AHzI9o/edit#heading=h.t5dgh0h3jo8kThe correct expectations is still a big question.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1175099
Change-Id: I8bb3f61177aee364ec438c5e05a3e1c5dc0d5148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785040
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868488}
@KyleJu
Copy link
Contributor

KyleJu commented Apr 5, 2021

/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/redirect.tentative.html is flaky both on Firefox and Chrome

Chrome:

Test Subtest Results Messages
/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/redirect.tentative.html   OK: 9/10, TIMEOUT: 1/10  
/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/redirect.tentative.html same-origin -> cross-origin FAIL: 9/10, TIMEOUT: 1/10 Test timed out;assert_equals: expected (undefined) undefined but got (string) "same_origin"

Firefox:

Test Subtest Results Messages
/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/redirect.tentative.html   OK: 8/10, TIMEOUT: 2/10  
/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/redirect.tentative.html same-origin -> cross-origin FAIL: 8/10, TIMEOUT: 2/10 Test timed out;assert_equals: expected (undefined) undefined but got (string) "same_origin"
/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/redirect.tentative.html cross-origin -> same-origin PASS: 9/10, TIMEOUT: 1/10 Test timed out
/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/redirect.tentative.html cross-origin -> cross-origin FAIL: 9/10, TIMEOUT: 1/10 Test timed out;assert_equals: expected (undefined) undefined but got (string) "same_origin"

@KyleJu
Copy link
Contributor

KyleJu commented Apr 6, 2021

Filed this bug. @LukeZielinski could you admin merge?

@ArthurSonzogni
Copy link
Member

@LukeZielinski
Copy link
Contributor

@foolip to admin merge.

@stephenmcgruer stephenmcgruer merged commit 76b0cd4 into master Apr 6, 2021
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-2785040 branch April 6, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants