Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8935: [OSX] Crash when clicking 'Save' due to wrongly-threaded OS call. #8944

Merged
merged 1 commit into from Apr 5, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Apr 4, 2021

Motivation / Problem

Possible crash when clicking 'Save' in the save dialog due to an OS function being called from the wrong thread when the focus of the editbox is relinquished upon closing.

Description

Asynchronously call the OS API to discard the current text input on the main thread to satisfy macOS.

Limitations

Only sparingly tested and slightly modified from what I posted in #8935 to better approximate current behaviour.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc added OS: MacOS This issue is related to a Mac OS problem backport requested This PR should be backport to current release (RC / stable) labels Apr 4, 2021
@andythenorth
Copy link
Contributor

Tested, this PR resolves the saving issue for me.

@michicc michicc merged commit 1cd3a3b into OpenTTD:master Apr 5, 2021
@michicc michicc deleted the pr/fix_8935 branch April 5, 2021 10:18
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 17, 2021
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable) OS: MacOS This issue is related to a Mac OS problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants