Fix: Use FluidSynth default soundfont #8953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
FluidSynth provides a build option to set a default soundfont which may be overridden by Linux distributions such as Debian to support alternative soundfont providers (such as Fluid, OPL-3, MuseScore, ...). This PR enables OpenTTD to use this default soundfont if present, which is arguably more flexible than maintaining the hard-coded list in the OpenTTD code base.
As an immediate benefit of this, the Flatpak build of OpenTTD will no longer require patching the hard-coded list. Instead, only FluidSynth needs to be configured with an appropriate default soundfont in place inside the runtime.
Description
The implementation now loads the default soundfont configured with FluidSynth, if any. The previous find-first lookup from the hard-coded soundfont list is still used as a fallback if no suitable default soundfont is found.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.