Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Move ImageDecoder API decoding over to sequenced worker thread." #28371

Merged
merged 1 commit into from Apr 6, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 5, 2021

This is a reland of a5f3d67b351ca099af4c447c9d91b6d445bf60d9

Original change's description:

Move ImageDecoder API decoding over to sequenced worker thread.

This moves the actual image decoding into a new ImageDecoderCore
class which can be used with WTF::SequenceBound to decode images
on a sequenced worker pool.

This follows the WebCodecs processing model where decoding is not
supposed to occur on the main thread.

Fixed: 1182435

Change-Id: I22a89d9242110fb17010f1fd178bcb5fc59fb5a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2799173
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869115}

Change-Id: Ic9db3fee402eb59d322dfdf228953b9ea0039f31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2803918
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869409}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This is a reland of a5f3d67b351ca099af4c447c9d91b6d445bf60d9

Original change's description:
> Move ImageDecoder API decoding over to sequenced worker thread.
>
> This moves the actual image decoding into a new ImageDecoderCore
> class which can be used with WTF::SequenceBound to decode images
> on a sequenced worker pool.
>
> This follows the WebCodecs processing model where decoding is not
> supposed to occur on the main thread.
>
> Fixed: 1182435
>
> Change-Id: I22a89d9242110fb17010f1fd178bcb5fc59fb5a1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2799173
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Reviewed-by: Yuta Kitamura <yutak@chromium.org>
> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#869115}

Change-Id: Ic9db3fee402eb59d322dfdf228953b9ea0039f31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2803918
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869409}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants