Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timout on css/css-grid/grid-definition/grid-repeat-max-width-001.html #28370

Closed
bfgeek opened this issue Apr 5, 2021 · 3 comments · Fixed by #28386
Closed

Timout on css/css-grid/grid-definition/grid-repeat-max-width-001.html #28370

bfgeek opened this issue Apr 5, 2021 · 3 comments · Fixed by #28386
Assignees
@tabatkins
Labels
css-grid

Comments

@bfgeek
Copy link
Contributor

bfgeek commented Apr 5, 2021

As above:
http://wpt.live/css/css-grid/grid-definition/grid-repeat-max-width-001.html

Initial commit was bad:
7e8d081
@tabatkins
Copy link
Contributor

Oh, huh, is that because it's a reftest but I've still included the testharness libs? I think this is the first reftest I've written from scratch.

@gsnedders
Copy link
Member

Oh, huh, is that because it's a reftest but I've still included the testharness libs? I think this is the first reftest I've written from scratch.

Indeed. It waits for all the (JS) tests to run to completion, but none ever start, yet alone complete.

@tabatkins tabatkins linked a pull request Apr 6, 2021 that will close this issue
Remove testharness; this is a reftest #28386
Merged
@tabatkins
Copy link
Contributor

Ah, thanks. I'll merge #28386 once it greens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabatkins tabatkins

Labels
css-grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove testharness; this is a reftest web-platform-tests/wpt
3 participants
@gsnedders @tabatkins @bfgeek