WebXR: fix getPose() logic #28372
Merged
WebXR: fix getPose() logic #28372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 5, 2021
XRFrame::getPose() should work for spaces when the relationship between them is known even if we have not received any poses from the device. This means that getPose(x, x) should return identity, and getPose(x, y) should also return something if y and x are statically offset from each other. XRFrame::getViewerPose(viewerSpace) should also follow the same rules. Also adds WPT to test the behavior and removes null checks in getPose() and getViewerPose() - the non-nullability is enforced by the bindings. Change-Id: If0119c834cfb6e0233d3152b840b0628a571fb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2803481 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#869806}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2803481
branch
from
6210cf3
to
ebabe38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRFrame::getPose() should work for spaces when the relationship between
them is known even if we have not received any poses from the device.
This means that getPose(x, x) should return identity, and getPose(x, y)
should also return something if y and x are statically offset from each
other. XRFrame::getViewerPose(viewerSpace) should also follow the same
rules.
Also adds WPT to test the behavior and removes null checks in getPose()
and getViewerPose() - the non-nullability is enforced by the bindings.
Change-Id: If0119c834cfb6e0233d3152b840b0628a571fb4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2803481
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869806}