Add a lint that checks paths are unique irrespective of case #28396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
force-pushed
the
duplicate_path_case_insensitive
branch
from
fcda430
to
020e300
Compare
Ms2ger
approved these changes
Apr 21, 2021
tools/lint/lint.py
Outdated
| @@ -396,6 +396,20 @@ def check_unique_testharness_basenames(repo_root, paths): | |||
| return errors | |||
|
|
|||
|
|
|||
| def check_unique_case_insensitive_paths(repo_root, paths): | |||
| # type: (Text, List[Text]) -> List[rules.Error] | |||
| seen = {} | |||
There was a problem hiding this comment.
tools/lint/lint.py:401: error: Need type annotation for 'seen' (hint: "seen: Dict[<type>, <type>] = ...")
Paths that are the same excluding case don't work reliably across operating systems and can be forbidden by vendor CI. So we should error on these paths in the lint.
jgraham
force-pushed
the
duplicate_path_case_insensitive
branch
from
020e300
to
d711d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths that are the same excluding case don't work reliably across
operating systems and can be forbidden by vendor CI. So we should
error on these paths in the lint.