Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install location of 'make install' #41

Merged
merged 1 commit into from Apr 7, 2021

Conversation

Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Apr 2, 2021

I noticed the 'make install' command copied the .tar file into the wrong location, so I corrected it.

@FLHerne
Copy link

FLHerne commented Apr 2, 2021

Good catch!

I think it would be better to keep the $(BASE_FILENAME) -- this would place all OpenSFX versions in baseset/opensfx/<file> which would be tidier if anyone is working with more than one sound set.

Per OTTD docs this should work fine:

| Sound Sets | baseset | (or a subdirectory thereof) |

Also note the commit checker error (commit message should be "Fix: ...").

Same comments apply to OpenTTD/OpenMSX#20.

@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented Apr 2, 2021

This should be fixed now.

@FLHerne
Copy link

FLHerne commented Apr 7, 2021

Looks good to me. Tested (on Linux) that the file is installed to the right place and OTTD picks it up.

@LordAro LordAro merged commit 71a54de into OpenTTD:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants