Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: adjust object and rail station selection window padding to be consistent #8929

Merged
merged 1 commit into from Apr 2, 2021

Conversation

perezdidac
Copy link
Contributor

Motivation / Problem

The object selection window and the rail station selection window have inconsistent UI paddings as well as their widgets.

Description

This code change makes widget paddings in the object selection and rail station selection windows consistent as well as matching the paddings of the road station window.

Before

image

After

image

Road station window (not changed, but for reference)

image

Limitations

Tested with different UI sizes, with and without NewGRFs.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Apr 2, 2021
@michicc michicc merged commit e760c9f into OpenTTD:master Apr 2, 2021
@perezdidac perezdidac deleted the win branch April 2, 2021 16:16
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 17, 2021
LordAro pushed a commit that referenced this pull request Apr 18, 2021
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants