Fix: Freeing LanguagePack with wrong size. #8899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
AddressSanitizer complains:
Description
Currently ReadFileToMem uses operator
new
directly to create object with given size. Afterwards it is reinterpreted to LanguagePack, and it is freed as such, but it is incorrect to free object with mismatched size. This makes AddressSanitizer complain.This PR removes hackery from ReadFileToMem and makes it return regular
char[]
. On side of language pack code, custom deleter is used inunique_ptr
to free reinterpreted pointer properly.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.