Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 00564a7d0912
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1c1c6c4b0057
Choose a head ref
  • 16 commits
  • 13 files changed
  • 8 contributors

Commits on Mar 8, 2021

  1. glib: 2.64.5 -> 2.64.6

    amaxine committed Mar 8, 2021
    Copy the full SHA
    175e921 View commit details

Commits on Mar 15, 2021

  1. openssh: 8.4p1 -> 8.5p1 and refactor

    Also split out the variants of the package because I'm sick of waiting
    for random patches to be updated before I can update my unpatched
    openssh.
    
    Also make pname correspond to the attribute name.
    
    (cherry picked from commit c99c499)
    dasJ committed Mar 15, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    8aabb84 View commit details
  2. openssh_hpn/openssh_gssapi: Add CVE-2021-28041

    (cherry picked from commit 2b1011d)
    dasJ committed Mar 15, 2021
    Copy the full SHA
    86f8de4 View commit details

Commits on Mar 20, 2021

  1. libtiff: fix two security issues

    CVE-2020-35523:
    An integer overflow flaw was found in libtiff that exists in the
    tif_getimage.c file. This flaw allows an attacker to inject and execute
    arbitrary code when a user opens a crafted TIFF file. The highest
    threat from this vulnerability is to confidentiality, integrity, as
    well as system availability.
    
    CVE-2020-35524:
    A heap-based buffer overflow flaw was found in libtiff in the handling
    of TIFF images in libtiff's TIFF2PDF tool. A specially crafted TIFF
    file can lead to arbitrary code execution. The highest threat from this
    vulnerability is to confidentiality, integrity, as well as system
    availability.
    
    Fixes: CVE-2020-35523, CVE-2020-35524
    mweinelt committed Mar 20, 2021
    Copy the full SHA
    3f40a5f View commit details
  2. Merge pull request #115439 from maxeaubrey/20.09_glib_2.64.6

    [20.09] glib: 2.64.5 -> 2.64.6
    mweinelt authored Mar 20, 2021
    Copy the full SHA
    98445ff View commit details
  3. Merge pull request #116280 from mweinelt/20.09/libtiff

    [20.09] libtiff: fix two security issues
    mweinelt authored Mar 20, 2021
    Copy the full SHA
    7b90c6f View commit details

Commits on Mar 21, 2021

  1. Copy the full SHA
    1e16bda View commit details
  2. popt: 1.16 -> 1.18

    (cherry picked from commit 2e4e20f)
    r-ryantm authored and dotlambda committed Mar 21, 2021
    Copy the full SHA
    bf59c47 View commit details

Commits on Mar 22, 2021

  1. Merge pull request #116431 from helsinki-systems/bp/openssh85

    [staging-20.09] openssh: 8.4p1 -> 8.5p1 and mark CVE-2021-28041
    roberth authored Mar 22, 2021
    Copy the full SHA
    44749ee View commit details
  2. Merge pull request #117082 from dotlambda/django_2-2.2.19

    [staging-20.09] python3Packages.django_2: 2.2.18 -> 2.2.19
    roberth authored Mar 22, 2021
    Copy the full SHA
    ab8e228 View commit details
  3. Merge #114192: gnutls: 3.6.15 -> 3.7.1

    It includes a low-severity security fix:
    https://gnutls.org/security-new.html#GNUTLS-SA-2021-03-10
    
    (cherry picked from commit a253ed2)
    vcunat committed Mar 22, 2021
    Copy the full SHA
    653b9a1 View commit details
  4. nettle: 3.6 -> 3.7.2 (security)

    https://lists.lysator.liu.se/pipermail/nettle-bugs/2021/009458.html
    It's meant to be fully compatible with 3.6, so we can fast-track it.
    
    (cherry picked from commit f688168)
    vcunat committed Mar 22, 2021
    Copy the full SHA
    f85d91e View commit details
  5. Copy the full SHA
    a335aa6 View commit details
  6. Merge pull request #117020 from dotlambda/popt-1.18

    [staging-20.09] popt: 1.16 -> 1.18
    roberth authored Mar 22, 2021
    Copy the full SHA
    5ce64bf View commit details

Commits on Mar 24, 2021

  1. Re-apply "unbound: 1.13.0 -> 1.13.1"

    master commit: a24b40b; moved to staging-20.09 in 36d15c7
    vcunat committed Mar 24, 2021
    Copy the full SHA
    3deaa4b View commit details

Commits on Mar 25, 2021

  1. Merge branch 'staging-20.09' into release-20.09

    The jobset on Hydra is >90% complete, so let's merge to update -small.
    https://hydra.nixos.org/eval/1657620
    vcunat committed Mar 25, 2021
    Copy the full SHA
    1c1c6c4 View commit details
4 changes: 2 additions & 2 deletions pkgs/development/libraries/glib/default.nix
Original file line number Diff line number Diff line change
@@ -45,11 +45,11 @@ in

stdenv.mkDerivation rec {
pname = "glib";
version = "2.64.5";
version = "2.64.6";

src = fetchurl {
url = "mirror://gnome/sources/glib/${stdenv.lib.versions.majorMinor version}/${pname}-${version}.tar.xz";
sha256 = "04fczq693wivkqd2qxvvi3sncqgznsvzfiiwsll1rbayf795pgcw";
sha256 = "1wakp3zl9hs7p86br415qhrq6dnnmjmfcvq18vq72k0nf1xf0vn3";
};

patches = optionals stdenv.isDarwin [
10 changes: 4 additions & 6 deletions pkgs/development/libraries/gnutls/default.nix
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@

assert guileBindings -> guile != null;
let
version = "3.6.15";
version = "3.7.1";

# XXX: Gnulib's `test-select' fails on FreeBSD:
# https://hydra.nixos.org/build/2962084/nixlog/1/raw .
@@ -23,8 +23,8 @@ stdenv.mkDerivation {
inherit version;

src = fetchurl {
url = "mirror://gnupg/gnutls/v3.6/gnutls-${version}.tar.xz";
sha256 = "0n0m93ymzd0q9hbknxc2ycanz49sqlkyyf73g9fk7n787llc7a0f";
url = "mirror://gnupg/gnutls/v3.7/gnutls-${version}.tar.xz";
sha256 = "0vxcbig87sdc73h58pmcpbi4al1zgcxid1jn67mhcpna7sbdfxrp";
};

outputs = [ "bin" "dev" "out" "man" "devdoc" ];
@@ -42,9 +42,7 @@ stdenv.mkDerivation {
# - trust-store: default trust store path (/etc/ssl/...) is missing in sandbox (3.5.11)
# - psk-file: no idea; it broke between 3.6.3 and 3.6.4
# Change p11-kit test to use pkg-config to find p11-kit
postPatch = lib.optionalString (lib.versionAtLeast version "3.4") ''
sed '2iecho "name constraints tests skipped due to datefudge problems"\nexit 0' -i tests/cert-tests/name-constraints
'' + lib.optionalString (lib.versionAtLeast version "3.6") ''
postPatch = lib.optionalString (lib.versionAtLeast version "3.6") ''
sed '2iexit 77' -i tests/{pkgconfig,fastopen}.sh
sed '/^void doit(void)/,/^{/ s/{/{ exit(77);/' -i tests/{trust-store,psk-file}.c
sed 's:/usr/lib64/pkcs11/ /usr/lib/pkcs11/ /usr/lib/x86_64-linux-gnu/pkcs11/:`pkg-config --variable=p11_module_path p11-kit-1`:' -i tests/p11-kit-trust.sh
27 changes: 27 additions & 0 deletions pkgs/development/libraries/libtiff/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ stdenv
, fetchurl
, fetchpatch

, pkgconfig

@@ -19,6 +20,32 @@ stdenv.mkDerivation rec {

outputs = [ "bin" "dev" "out" "man" "doc" ];

patches = [
# https://gitlab.com/libtiff/libtiff/-/merge_requests/160
(fetchpatch {
name = "CVE-2020-35523.1.patch";
url = "https://gitlab.com/libtiff/libtiff/-/commit/712fe9f5b9795c5a3e80f38db90dad11e6a8bb6a.patch";
sha256 = "1h4jrilnhc50qzjxljcm0471i4inwr790b1dzdf6qvwf7fqi6wky";
})
(fetchpatch {
name = "CVE-2020-35523.2.patch";
url = "https://gitlab.com/libtiff/libtiff/-/commit/c8d613ef497058fe653c467fc84c70a62a4a71b2.patch";
sha256 = "01rzwf5xk5mf3j362g74h9qc45cnmqr0c14w5xj3p8mk160cd74q";
})
# https://gitlab.com/libtiff/libtiff/-/merge_requests/159
(fetchpatch {
name = "CVE-2020-35524.1.patch";
url = "https://gitlab.com/libtiff/libtiff/-/commit/c6a12721b46f1a72974f91177890301730d7b330.patch";
sha256 = "1lac51lsvap6wzdg1rssnq2adrpxd3bqrsdm40qd88mpa0g3rsfb";
})
(fetchpatch {
name = "CVE-2020-35524.2.patch";
url = "https://gitlab.com/libtiff/libtiff/-/commit/d74f56e3b7ea55c8a18a03bc247cd5fd0ca288b2.patch";
sha256 = "0v559fpsgnmhzgjhsp7fkm3hwrfjv2042lrczd32c0yb9jbrqxvi";
})

];

nativeBuildInputs = [ pkgconfig ];

propagatedBuildInputs = [ zlib libjpeg xz ]; #TODO: opengl support (bogus configure detection)
4 changes: 2 additions & 2 deletions pkgs/development/libraries/nettle/default.nix
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{ callPackage, fetchurl, ... } @ args:

callPackage ./generic.nix (args // rec {
version = "3.6";
version = "3.7.2";

src = fetchurl {
url = "mirror://gnu/nettle/nettle-${version}.tar.gz";
sha256 = "1wg3sprl0bzy49cmbwwm91vw67hk1x5i3ksdygsciyxz587hsk6j";
sha256 = "0qpi1qp3bcvqdsaxy2pzg530db95x8qjahkynxgwvr6dy5760ald";
};
})
2 changes: 1 addition & 1 deletion pkgs/development/libraries/nettle/generic.nix
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ stdenv.mkDerivation ({
nativeBuildInputs = [ gnum4 ];
propagatedBuildInputs = [ gmp ];

configureFlags = [ "--enable-fat" ]; # runtime selection of HW-accelerated code
configureFlags = [ "--enable-fat" ]; # runtime selection of HW-accelerated code; it's default since 3.7

doCheck = (stdenv.hostPlatform.system != "i686-cygwin" && !stdenv.isDarwin);

4 changes: 2 additions & 2 deletions pkgs/development/libraries/popt/default.nix
Original file line number Diff line number Diff line change
@@ -2,11 +2,11 @@

stdenv.mkDerivation rec {
pname = "popt";
version = "1.16";
version = "1.18";

src = fetchurl {
url = "mirror://debian/pool/main/p/popt/popt_${version}.orig.tar.gz";
sha256 = "1j2c61nn2n351nhj4d25mnf3vpiddcykq005w2h6kw79dwlysa77";
sha256 = "1lf5zlj5rbg6s4bww7hbhpca97prgprnarx978vcwa0bl81vqnai";
};

patches = stdenv.lib.optionals stdenv.isCygwin [
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/django/2_2.nix
Original file line number Diff line number Diff line change
@@ -6,13 +6,13 @@

buildPythonPackage rec {
pname = "Django";
version = "2.2.18";
version = "2.2.19";

disabled = !isPy3k;

src = fetchPypi {
inherit pname version;
sha256 = "1d0b91343i9n0qz8xia1fbm4s3q8wi98nyc9a3acncm0w3sr9jf9";
sha256 = "0hysjf8bz4g8xrn2cdx6pmawimpyr6ag2fg3jxsnc1byr3g3bhih";
};

patches = stdenv.lib.optional withGdal
116 changes: 116 additions & 0 deletions pkgs/tools/networking/openssh/common.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
{ pname
, version
, extraDesc ? ""
, src
, extraPatches ? []
, extraNativeBuildInputs ? []
, extraMeta ? {}
}:

{ lib, stdenv
, fetchurl
, fetchpatch
, zlib
, openssl
, libedit
, pkg-config
, pam
, etcDir ? null
, withKerberos ? true
, kerberos
, libfido2
, withFIDO ? stdenv.hostPlatform.isUnix && !stdenv.hostPlatform.isMusl
, linkOpenssl ? true
}:

with lib;
stdenv.mkDerivation rec {
inherit pname version src;

patches = [
./locale_archive.patch

# See discussion in https://github.com/NixOS/nixpkgs/pull/16966
./dont_create_privsep_path.patch
] ++ extraPatches;

postPatch =
# On Hydra this makes installation fail (sometimes?),
# and nix store doesn't allow such fancy permission bits anyway.
''
substituteInPlace Makefile.in --replace '$(INSTALL) -m 4711' '$(INSTALL) -m 0711'
'';

nativeBuildInputs = [ pkg-config ]
++ optional withKerberos kerberos.dev
++ extraNativeBuildInputs;
buildInputs = [ zlib openssl libedit ]
++ optional withFIDO libfido2
++ optional withKerberos kerberos
++ optional stdenv.isLinux pam;

preConfigure = ''
# Setting LD causes `configure' and `make' to disagree about which linker
# to use: `configure' wants `gcc', but `make' wants `ld'.
unset LD
''
# Upstream build system does not support static build, so we fall back
# on fragile patching of configure script.
#
# libedit is found by pkg-config, but without --static flag, required
# to get also transitive dependencies for static linkage, hence sed
# expression.
#
# Kerberos can be found either by krb5-config or by fall-back shell
# code in openssh's configure.ac. Neither of them support static
# build, but patching code for krb5-config is simpler, so to get it
# into PATH, kerberos.dev is added into buildInputs.
+ optionalString stdenv.hostPlatform.isStatic ''
sed -i "s,PKGCONFIG --libs,PKGCONFIG --libs --static,g" configure
sed -i 's#KRB5CONF --libs`#KRB5CONF --libs` -lkrb5support -lkeyutils#g' configure
sed -i 's#KRB5CONF --libs gssapi`#KRB5CONF --libs gssapi` -lkrb5support -lkeyutils#g' configure
'';

# I set --disable-strip because later we strip anyway. And it fails to strip
# properly when cross building.
configureFlags = [
"--sbindir=\${out}/bin"
"--localstatedir=/var"
"--with-pid-dir=/run"
"--with-mantype=man"
"--with-libedit=yes"
"--disable-strip"
(if stdenv.isLinux then "--with-pam" else "--without-pam")
] ++ optional (etcDir != null) "--sysconfdir=${etcDir}"
++ optional withFIDO "--with-security-key-builtin=yes"
++ optional withKerberos (assert kerberos != null; "--with-kerberos5=${kerberos}")
++ optional stdenv.isDarwin "--disable-libutil"
++ optional (!linkOpenssl) "--without-openssl";

buildFlags = [ "SSH_KEYSIGN=ssh-keysign" ];

enableParallelBuilding = true;

hardeningEnable = [ "pie" ];

postInstall = ''
# Install ssh-copy-id, it's very useful.
cp contrib/ssh-copy-id $out/bin/
chmod +x $out/bin/ssh-copy-id
cp contrib/ssh-copy-id.1 $out/share/man/man1/
'';

installTargets = [ "install-nokeys" ];
installFlags = [
"sysconfdir=\${out}/etc/ssh"
];

meta = {
description = "An implementation of the SSH protocol${extraDesc}";
homepage = "https://www.openssh.com/";
changelog = "https://www.openssh.com/releasenotes.html";
license = licenses.bsd2;
platforms = platforms.unix ++ platforms.windows;
maintainers = with maintainers; [ eelco aneeshusa ];
} // extraMeta;
}
Loading